logs member name changed to logger when referring to LogCollector inspector#5498
Merged
Evalir merged 3 commits intofoundry-rs:masterfrom Aug 2, 2023
Merged
logs member name changed to logger when referring to LogCollector inspector#5498Evalir merged 3 commits intofoundry-rs:masterfrom
Evalir merged 3 commits intofoundry-rs:masterfrom
Conversation
aathan
changed the title
Closed
aathan
added a commit
to aathan/foundry
that referenced
this pull request
Aug 3, 2023
…pector (foundry-rs#5498) * logs to logger when referring to LogCollector inspector * missing file * chore: rename to log collector --------- Co-authored-by: AA <aa@aa> Co-authored-by: Enrique Ortiz <hi@enriqueortiz.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To make the source code clearer, and searching for places where the code is touching the log inspector vs the collected logs, and to make the naming more consistent with its brethren (like "tracer"), I've renamed the struct members in InspectorStack and Inspector from logs to logger.
Solution
Symbol name change.