feat(forge): support for console.log on Invariant handlers#5488
Merged
feat(forge): support for console.log on Invariant handlers#5488
forge): support for console.log on Invariant handlers#5488Conversation
Evalir
force-pushed
the
evalir/invariant-console-logs
branch
from
9a152fb to
5ec303e
Compare
Member
Author
|
hey hey @mds1 mind sanity testing this too? this is a highly requested feature so wanna make sure all is good ^^ |
Collaborator
|
For sure, again tagging @lucas-manuel and @PaulRBerg for testing assistance too 😁 |
Member
Author
|
cc @mattsse this should be good for another review round—functionality is sound |
mattsse
approved these changes
Aug 10, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4951
Solution
Adds support for console logs on invariant handlers, by persisting the logs and traces for the last call.
To avoid any performance regressions we only move values and only copy where absolutely necessary (filling each invariant with the corresponding logs at the end), and only persist the call values at the end of each run campaign, as they would just be overwriting values persisted at the stack otherwise.