Closed
Conversation
mattsse
requested changes
May 20, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
sorry forgot to review this.
I like this, but it needs a rebase because we moved cheatcodes
mattsse
reviewed
Jun 9, 2023
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
looks like this just needs a rebase?
mattsse
approved these changes
Jun 15, 2023
Member
|
there's a failing test, otherwise lgtm |
Member
Author
|
yeah need to debug why this is failing—the cheatcode actually always reverts for some reason. need to test further before merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2932 .
Solution
Adds a
tryFficheatcode, which returns aFfiResultstruct which contains:exit_codestdoutas bytes.stderras bytes.