Skip to content

fix(chisel): upgrade default solc version to 0.8.19 #4890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattsse merged 2 commits into from
May 8, 2023
Merged

fix(chisel): upgrade default solc version to 0.8.19 #4890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c67bb8
fix(chisel): upgrade default solc version to 0.8.19
Evalir May 7, 2023
fa47c69
chore: clippy happy
Evalir May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions anvil/server/src/ipc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,8 @@ impl tokio_util::codec::Decoder for JsonRpcCodec {
} else if is_whitespace(byte) {
whitespaces += 1;
}
if byte == b'\\' && !is_escaped && in_str {
is_escaped = true;
} else {
is_escaped = false;
}

is_escaped = byte == b'\\' && !is_escaped && in_str;

if depth == 0 && idx != start_idx && idx - start_idx + 1 > whitespaces {
let bts = buf.split_to(idx + 1);
Expand Down
4 changes: 2 additions & 2 deletions chisel/src/session_source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ impl SessionSourceConfig {
/// Solc version precedence
/// - Foundry configuration / `--use` flag
/// - Latest installed version via SVM
/// - Default: Latest 0.8.17
/// - Default: Latest 0.8.19
pub(crate) fn solc(&self) -> Result<Solc> {
let solc_req = if let Some(solc_req) = self.foundry_config.solc.clone() {
solc_req
Expand All @@ -95,7 +95,7 @@ impl SessionSourceConfig {
print!("{}", Paint::green("No solidity versions installed! "));
}
// use default
SolcReq::Version("0.8.17".parse().unwrap())
SolcReq::Version("0.8.19".parse().unwrap())
};

match solc_req {
Expand Down
2 changes: 1 addition & 1 deletion cli/src/cmd/forge/coverage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ impl CoverageArgs {
CoverageReportKind::Lcov => {
LcovReporter::new(&mut fs::create_file(root.join("lcov.info"))?).report(&report)
}
CoverageReportKind::Debug => DebugReporter::default().report(&report),
CoverageReportKind::Debug => DebugReporter.report(&report),
}?;
}
Ok(())
Expand Down
2 changes: 1 addition & 1 deletion common/src/provider.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ impl ProviderBuilder {
.rate_limit_retries(max_retry)
.timeout_retries(timeout_retry)
.compute_units_per_second(compute_units_per_second)
.build(provider, Box::new(HttpRateLimitRetryPolicy::default())),
.build(provider, Box::new(HttpRateLimitRetryPolicy)),
);

if is_local {
Expand Down