Conversation
mattsse
left a comment
There was a problem hiding this comment.
incredible work!
even if all the conversions are a bit horrible, we need to do this to support revm and they will become obsolete eventually.
could you please enable contributions by mainter? I have a few local changes that I'd like to push.
I think the issue is that you opened with master branch which is perhaps protected?
a few tests hang but I suspect they're are related to infura/goerli rpc keys.
so before we continue we need to update those, ref #4781
but this looks pretty good, can merge once tests green!
|
Aight all tests seem to be fixed but CI is hanged on this last one ( To add to the investigation, I tried doing both:
UPDATE: See foundry-rs/forge-std#363 and the associated PR—flaky test has been commented out, this fixed CI for the time being. |
mattsse
left a comment
There was a problem hiding this comment.
alright, let's do a final rebase then send it
|
I christen thee, v1.0.0 |
Motivation
REVM needed to be updated to the latest version (3.x) so we can start working on the big rewrites & new features.
Solution
Migrates types/imports to conform to 3.x. These changes are focused on converting types—I'm deliberately choosing to keep the existing types that don't conflict there for now. The strategy is more or less as follows:
All of the types that need to use the revm types (e.g trait impls or structs/traits that interact very closely with revm) are switched.
Everything else is just converted when needed (see evm crate utils for utility functions)
Note that I've let some lints purposely fail because these are areas that need confirmation as logic changed around them.
There's also the old PR for historical comments.