Skip to content

REVM: 3.x Migration#4757

Merged
mattsse merged 40 commits intofoundry-rs:masterfrom
Evalir:master
Apr 29, 2023
Merged

REVM: 3.x Migration#4757
mattsse merged 40 commits intofoundry-rs:masterfrom
Evalir:master

Conversation

@Evalir
Copy link
Member

@Evalir Evalir commented Apr 17, 2023

Motivation

REVM needed to be updated to the latest version (3.x) so we can start working on the big rewrites & new features.

Solution

Migrates types/imports to conform to 3.x. These changes are focused on converting types—I'm deliberately choosing to keep the existing types that don't conflict there for now. The strategy is more or less as follows:

All of the types that need to use the revm types (e.g trait impls or structs/traits that interact very closely with revm) are switched.
Everything else is just converted when needed (see evm crate utils for utility functions)

Note that I've let some lints purposely fail because these are areas that need confirmation as logic changed around them.

There's also the old PR for historical comments.

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incredible work!

even if all the conversions are a bit horrible, we need to do this to support revm and they will become obsolete eventually.

could you please enable contributions by mainter? I have a few local changes that I'd like to push.
I think the issue is that you opened with master branch which is perhaps protected?

a few tests hang but I suspect they're are related to infura/goerli rpc keys.
so before we continue we need to update those, ref #4781

but this looks pretty good, can merge once tests green!

@Evalir
Copy link
Member Author

Evalir commented Apr 27, 2023

Aight all tests seem to be fixed but CI is hanged on this last one (test_cmd::can_test_forge_std). As you mentioned @mattsse it could probably be the keys—how should we proceed?

To add to the investigation, I tried doing both:

  • testing forge-std with the latest nightly, and it hangs up.
  • testing forge-std with this branch, and it also hangs.

UPDATE: See foundry-rs/forge-std#363 and the associated PR—flaky test has been commented out, this fixed CI for the time being.

@Evalir Evalir requested a review from mattsse April 28, 2023 13:50
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, let's do a final rebase then send it

@mattsse mattsse merged commit e7f8ee8 into foundry-rs:master Apr 29, 2023
@mattsse mattsse added the A-evm Area: EVM label Apr 29, 2023
@sambacha
Copy link
Contributor

I christen thee, v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-evm Area: EVM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants