Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing debug derive and update spinner message #1478

Merged
merged 1 commit into from
May 3, 2022
+6 −2
Merged

chore: add missing debug derive and update spinner message #1478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cli/src/term.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ impl Spinner {
/// A spinner used as [`ethers::solc::report::Reporter`]
///
/// This reporter will prefix messages with a spinning cursor
#[derive(Debug)]
pub struct SpinnerReporter {
/// the timeout in ms
sender: Arc<Mutex<mpsc::Sender<SpinnerMsg>>>,
Expand Down Expand Up @@ -232,12 +233,15 @@ impl Reporter for SpinnerReporter {
fn on_solc_success(
&self,
_solc: &Solc,
_version: &Version,
version: &Version,
output: &CompilerOutput,
duration: &Duration,
) {
self.solc_io_report.log_compiler_output(output);
self.send_msg(format!("Solc finished in {:.2?}", duration));
self.send_msg(format!(
"Solc {}.{}.{} finished in {:.2?}",
version.major, version.minor, version.patch, duration
));
}

/// Invoked before a new [`Solc`] bin is installed
Expand Down