Conversation
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse and
onbjerg
as code owners
grandizzy
approved these changes
Nov 12, 2025
| cmd.with_no_redact().assert_failure().stdout_eq(str![[r#" | ||
| ... | ||
| Compiling 2 files with [..] | ||
| Compiling 3 files with [..] |
Collaborator
There was a problem hiding this comment.
that's fine from compilers bump
0xrusowsky
approved these changes
Nov 12, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
Bumps Revm to 33, currently requires patch to address bug in latest release: bluealloy/revm#3164
Some breaking changes that now force passing in the
dbFor now I've set
was_precompile_calledtotruefor any CallOutcome that is not a revert but I am not sure if this is correct.PR Checklist