docs: add note back about large toml numbers#1237
Merged
mattsse merged 1 commit intofoundry-rs:masterfrom Apr 8, 2022
mattsse:matt/chore-add-i64-note-back
Merged
docs: add note back about large toml numbers#1237mattsse merged 1 commit intofoundry-rs:masterfrom mattsse:matt/chore-add-i64-note-back
mattsse merged 1 commit intofoundry-rs:masterfrom
mattsse:matt/chore-add-i64-note-back
Conversation
Member
|
So this effectively means that you can only lower the gas limit? |
Member
Author
only wanted to insert the comment not update the value... |
Member
|
Oh, right, I also misunderstood something |
onbjerg
approved these changes
Apr 8, 2022
Member
|
Wait, no, I'm right: The max value for a u64 is |
Member
Author
|
perhaps I can find a solution with a custom wrapper type |
Member
|
Can just merge this since it's a comment and then we fix it later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
add note back removed in #918
Solution