Skip to content

docs: add note back about large toml numbers#1237

Merged
mattsse merged 1 commit intofoundry-rs:masterfrom
mattsse:matt/chore-add-i64-note-back
Apr 8, 2022
Merged

docs: add note back about large toml numbers#1237
mattsse merged 1 commit intofoundry-rs:masterfrom
mattsse:matt/chore-add-i64-note-back

Conversation

@mattsse
Copy link
Member

@mattsse mattsse commented Apr 8, 2022

Motivation

add note back removed in #918

Solution

@onbjerg
Copy link
Member

onbjerg commented Apr 8, 2022

So this effectively means that you can only lower the gas limit?

@onbjerg onbjerg added the L-ignore Log: ignore PR in changelog label Apr 8, 2022
@mattsse
Copy link
Member Author

mattsse commented Apr 8, 2022

So this effectively means that you can only lower the gas limit?

only wanted to insert the comment not update the value...

@onbjerg
Copy link
Member

onbjerg commented Apr 8, 2022

Oh, right, I also misunderstood something

@onbjerg
Copy link
Member

onbjerg commented Apr 8, 2022

Wait, no, I'm right: The max value for a u64 is 18446744073709551615 - our default is half of that, which is 9223372036854775807, which also happens to be the max value of an i64. So you can effectively only lower the gas limit because of this bug :S

@mattsse
Copy link
Member Author

mattsse commented Apr 8, 2022

perhaps I can find a solution with a custom wrapper type

@onbjerg
Copy link
Member

onbjerg commented Apr 8, 2022

Can just merge this since it's a comment and then we fix it later

@mattsse mattsse merged commit ac9141d into foundry-rs:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L-ignore Log: ignore PR in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants