Skip to content

Conversation

@kilavvy
Copy link

@kilavvy kilavvy commented Oct 21, 2025

This PR removes the redundant _non_mut suffix from two public methods in CheatsConfig to improve API consistency and readability.

  • Renamed get_chain_data_by_alias_non_mutget_chain_data_by_alias
  • Renamed get_rpc_url_non_mutget_rpc_url
  • Updated internal method call to use the new name

The _non_mut suffix was redundant since:

  • Methods already use &self (non-mutating by design)
  • Other methods in the same struct follow the pattern without such suffixes (rpc_endpoint, rpc_urls, set_chain_data)

@onbjerg
Copy link
Contributor

onbjerg commented Oct 22, 2025

These functions are basically unused, removed in #12245

@onbjerg onbjerg closed this Oct 22, 2025
@github-project-automation github-project-automation bot moved this to Done in Foundry Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants