feat(forge-lint): new LateLintPass + support code snippets

Cargo.toml

@@ -204,15 +204,15 @@ foundry-wallets = { path = "crates/wallets" }
 foundry-linking = { path = "crates/linking" }
 
 # solc & compilation utilities
-foundry-block-explorers = { version = "0.19.1", default-features = false }
-foundry-compilers = { version = "0.17.4", default-features = false }
+foundry-block-explorers = { version = "0.20.0", default-features = false }
+foundry-compilers = { version = "0.18.0", default-features = false }
 foundry-fork-db = "0.16"
 solang-parser = { version = "=0.3.9", package = "foundry-solang-parser" }
-solar-ast = { version = "=0.1.4", default-features = false }
-solar-parse = { version = "=0.1.4", default-features = false }
-solar-interface = { version = "=0.1.4", default-features = false }
-solar-sema = { version = "=0.1.4", default-features = false }
-solar-data-structures = { version = "=0.1.4", default-features = false }
+solar-ast = { version = "=0.1.5", default-features = false }
+solar-parse = { version = "=0.1.5", default-features = false }
+solar-interface = { version = "=0.1.5", default-features = false }
+solar-sema = { version = "=0.1.5", default-features = false }
+solar-data-structures = { version = "=0.1.5", default-features = false }
 
 ## alloy
 alloy-consensus = { version = "1.0.22", default-features = false }

crates/chisel/src/solidity_helper.rs

@@ -53,7 +53,7 @@ impl SolidityHelper {
             errored: false,
             do_paint: yansi::is_enabled(),
             sess: Session::builder().with_silent_emitter(None).build(),
-            globals: SessionGlobals::new(),
+            globals: SessionGlobals::default(),
         }
     }
 

crates/cli/src/opts/build/utils.rs

@@ -14,22 +14,27 @@ use std::path::PathBuf;
 ///
 /// * Configures include paths, remappings and registers all in-memory sources so that solar can
 ///   operate without touching disk.
+/// * If no `project` is provided, it will spin up a new ephemeral project.
 /// * If no `target_paths` are provided, all project files are processed.
 /// * Only processes the subset of sources with the most up-to-date Solitidy version.
 pub fn solar_pcx_from_build_opts<'sess>(
     sess: &'sess Session,
-    build: BuildOpts,
-    target_paths: Option<Vec<PathBuf>>,
+    build: &BuildOpts,
+    project: Option<&Project>,
+    target_paths: Option<&[PathBuf]>,
 ) -> Result<ParsingContext<'sess>> {
     // Process build options
     let config = build.load_config()?;
-    let project = config.ephemeral_project()?;
+    let project = match project {
+        Some(project) => project,
+        None => &config.ephemeral_project()?,
+    };
 
     let sources = match target_paths {
         // If target files are provided, only process those sources
         Some(targets) => {
             let mut sources = Sources::new();
-            for t in targets.into_iter() {
+            for t in targets {
                 let path = dunce::canonicalize(t)?;
                 let source = Source::read(&path)?;
                 sources.insert(path, source);
@@ -44,7 +49,7 @@ pub fn solar_pcx_from_build_opts<'sess>(
     let graph = Graph::<MultiCompilerParsedSource>::resolve_sources(&project.paths, sources)?;
     let (version, sources, _) = graph
         // resolve graph into mapping language -> version -> sources
-        .into_sources_by_version(&project)?
+        .into_sources_by_version(project)?
         .sources
         .into_iter()
         // only interested in Solidity sources
@@ -63,7 +68,7 @@ pub fn solar_pcx_from_build_opts<'sess>(
         version,
     );
 
-    Ok(solar_pcx_from_solc_project(sess, &project, &solc, true))
+    Ok(solar_pcx_from_solc_project(sess, project, &solc, true))
 }
 
 /// Builds a Solar [`solar_sema::ParsingContext`] from a  [`foundry_compilers::Project`] and a

crates/forge/src/cmd/build.rs

@@ -3,18 +3,18 @@ use clap::Parser;
 use eyre::Result;
 use forge_lint::{linter::Linter, sol::SolidityLinter};
 use foundry_cli::{
-    opts::BuildOpts,
+    opts::{BuildOpts, solar_pcx_from_build_opts},
     utils::{LoadConfig, cache_local_signatures},
 };
 use foundry_common::{compile::ProjectCompiler, shell};
 use foundry_compilers::{
-    Project, ProjectCompileOutput,
+    CompilationError, FileFilter, Project, ProjectCompileOutput,
     compilers::{Language, multi::MultiCompilerLanguage},
     solc::SolcLanguage,
     utils::source_files_iter,
 };
 use foundry_config::{
-    Config,
+    Config, SkipBuildFilters,
     figment::{
         self, Metadata, Profile, Provider,
         error::Kind::InvalidType,
@@ -103,8 +103,6 @@ impl BuildArgs {
             .ignore_eip_3860(self.ignore_eip_3860)
             .bail(!format_json);
 
-        // Runs the SolidityLinter before compilation.
-        self.lint(&project, &config)?;
         let output = compiler.compile(&project)?;
 
         // Cache project selectors.
@@ -114,6 +112,11 @@ impl BuildArgs {
             sh_println!("{}", serde_json::to_string_pretty(&output.output())?)?;
         }
 
+        // Only run the `SolidityLinter` if there are no compilation errors
+        if output.output().errors.iter().all(|e| !e.is_error()) {
+            self.lint(&project, &config)?;
+        }
+
         Ok(output)
     }
 
@@ -147,15 +150,35 @@ impl BuildArgs {
                 .flat_map(foundry_common::fs::canonicalize_path)
                 .collect::<Vec<_>>();
 
+            let skip = SkipBuildFilters::new(config.skip.clone(), config.root.clone());
             let curr_dir = std::env::current_dir()?;
             let input_files = config
                 .project_paths::<SolcLanguage>()
                 .input_files_iter()
-                .filter(|p| !(ignored.contains(p) || ignored.contains(&curr_dir.join(p))))
+                .filter(|p| {
+                    skip.is_match(p)
+                        && !(ignored.contains(p) || ignored.contains(&curr_dir.join(p)))
+                })
                 .collect::<Vec<_>>();
 
             if !input_files.is_empty() {
-                linter.lint(&input_files);
+                let sess = linter.init();
+
+                let pcx = solar_pcx_from_build_opts(
+                    &sess,
+                    &self.build,
+                    Some(project),
+                    Some(&input_files),
+                )?;
+                linter.early_lint(&input_files, pcx);
+
+                let pcx = solar_pcx_from_build_opts(
+                    &sess,
+                    &self.build,
+                    Some(project),
+                    Some(&input_files),
+                )?;
+                linter.late_lint(&input_files, pcx);
             }
         }