refactor: flatten bind_json.rs to one pass without state structs #10791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the bind_json implementation to eliminate the intermediate state structs (PreprocessedState, StructsState, ResolvedState) and flatten the logic into a single pass through the workflow. All logic now resides within methods on BindJsonArgs, making the code more straightforward while preserving the same functionality.
DaniPopes
requested review from
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
- Change &PathBuf to &Path in function parameter - Remove unnecessary borrows - Change &mut Vec to &mut slice - Add Path import
0xrusowsky
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the bind_json implementation to eliminate the intermediate state structs and flatten the logic into a single pass through the workflow.
Previously the implementation used three state structs (
PreprocessedState,StructsState,ResolvedState) that were passed sequentially through the workflow. This change consolidates all logic into methods onBindJsonArgs, making the code more straightforward while preserving the same functionality.The main
run()method now clearly shows the 4 steps:All the original logic for preprocessing, finding structs, resolving conflicts, and writing bindings remains intact.