test(cast): add tests for EIP-712 type names with colons #10772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases to ensure cast can parse EIP-712 typed data when type names contain colons, which are valid according to the EIP-712 specification. Closes #10765
mattsse
requested review from
DaniPopes,
grandizzy,
klkvr,
yash-atreya and
zerosnacks
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add test cases to ensure cast can parse EIP-712 typed data when type names contain colons, which are valid according to the EIP-712 specification.
Description
This PR adds two test cases:
Test:Message)These tests ensure that cast properly supports the full EIP-712 specification, including type names with colons as used by protocols like Hyperliquid.
Related Issues
Closes #10765
Notes
This PR depends on the fix in alloy-rs/core#963