feat: Add anvil set erc20 allowance endpoint #10746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately anvil has the parameter order (owner, token) while tenderly has (token, owner), so they are not compatible. Fixing my previous mistake here.
pistomat
requested review from
DaniPopes,
grandizzy,
klkvr,
mattsse,
yash-atreya and
zerosnacks
as code owners
|
hey @pistomat mind to resolve conflicts in order to approve and run CI? thank you |
…/add-anvil-set-erc20-allowance-endpoint
|
@grandizzy done |
is this otherwise the same impl, if so we should consider changing the order |
mattsse
approved these changes
Jun 10, 2025
grandizzy
reviewed
Jun 10, 2025
|
agreed on the above, other than that implementation lgtm 👍 , supportive of having this endpoint |
|
yeah, but def easier to do this in a followup |
zerosnacks
approved these changes
Jun 10, 2025
mattsse
added a commit
that referenced
this pull request
Jun 10, 2025
Extracts duplicated access list handling code from `anvil_deal_erc20` and `anvil_set_erc20_allowance` into a shared `find_erc20_storage_slot` helper function. Changes: - Add comprehensive documentation explaining the slot discovery process - Reduce code duplication by ~80 lines - Improve maintainability and consistency between functions - Fix unfulfilled clippy expectation in cast/tx.rs This is a follow-up cleanup to #10746 which introduced `anvil_set_erc20_allowance`. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
mattsse
added a commit
that referenced
this pull request
Jun 10, 2025
* refactor: unify ERC20 storage slot discovery logic Extracts duplicated access list handling code from `anvil_deal_erc20` and `anvil_set_erc20_allowance` into a shared `find_erc20_storage_slot` helper function. Changes: - Add comprehensive documentation explaining the slot discovery process - Reduce code duplication by ~80 lines - Improve maintainability and consistency between functions - Fix unfulfilled clippy expectation in cast/tx.rs This is a follow-up cleanup to #10746 which introduced `anvil_set_erc20_allowance`. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]> * chore: add clippy back --------- Co-authored-by: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I love the new
anvil_dealERC20endpoint! So why not add an endpoint to override allowances? I present you the brand newanvil_setERC20Allowanceendpoint! One should not exist without the other imho, it is very useful to have both.Solution
Basically copied the code from
anvil_dealERC20and modified it to use theallowance(owner,spender,val)function of ERC20.Note: I also fixed my mistake of adding
tenderly_setErc20Balancealias, but Tenderly has different order of parameters, so it would be very confusing.PR Checklist