feat(forge): implement vm.signTypedData cheatcode

[Haxry]

Motivation

Solution

closes #10281

PR Checklist

• Added Tests
• Added Documentation
• Breaking changes

[grandizzy]

@Haxry pls don't introduce ethers dep bit use alloy. Also pls add a test for the new cheatcodes and make sure priv key is redacted in traces, you can add here

foundry/crates/evm/traces/src/decoder/mod.rs

Line 460 in 709f266

"signDelegation" | "signAndAttachDelegation" => {

Thanks

[Haxry]

@grandizzy
plz review !
are the changes ok ?
I'll add the test too !

[grandizzy]

@grandizzy plz review ! are the changes ok ? I'll add the test too !

yep, lgtm! I run cargo cheats and pushed commit to fix CI, would be great to have a test and then can be merged, maybe @aviggiano have a solidity test to use here?

[aviggiano]

Hey
Thanks for implementing this feature. I'll test it on my project today

[grandizzy]

Hey Thanks for implementing this feature. I'll test it on my project today

Awesome, thanks. Mind that the PR wasn't merged yet so you'll need to build locally and test, was wondering if you could provide a sample for input / output to include as a test.

[0xrusowsky]

@Haxry i finally took over cause we want to integrate this feature asap, as 2 other PRs that implement eip712-related cheatcodes will be merged soon. Regardless of that, thanks for your contribution!

fyi, i've named the cheatcode that produces the digest vm.eip712HashTypedData so that it follows the same naming convention as the other two:

• feat(forge): cheatcode eip712 #10570
• chore(forge): cheat eip712 struct hash #10626

the vm.signTypedData hasn't been renamed, as it already follows the naming standard of the "crypto" cheatcodes

@aviggiano please lmk if this is what u needed

[0xrusowsky]

@grandizzy i noticed that signDelegation and signAndAttachDelegation are under the Scripting group, however signTypedData is under Crypto.

does it matter? should we change its group perhaps?

[aviggiano]

@0xrusowsky thanks

I still don't see how I can sign without a private key, though

My goal is to use EIP-712 with ledger. How would I accomplish this with the current cheatcode?

[0xrusowsky]

@0xrusowsky thanks

I still don't see how I can sign without a private key, though

My goal is to use EIP-712 with ledger. How would I accomplish this with the current cheatcode?

my bad, i should have read more carefully the previous convos that u had... now i see that u want to get rid of the FFI dependency

[0xrusowsky]

@aviggiano if the cheatcode were to simply perfom the ffi call to cast under the hood, and adopt this API:

    /// Signs human-readable typed data `jsonData` using a hardware wallet.
    ///
    /// This cheatcode performs a foreign function call to `cast` to abstract away complexity of
    /// manually building the calldata. Because of that, it requires the FFI cheatcode to be enabled.
    ///
    /// # Params:
    ///
    /// * jsonData: the typed data must follow the EIP-712 standard.
    /// * walletType: the hardware wallet type, either "ledger" or "trezor".
    /// * walletArgs: the wallet derivation path or the mnemonic index.
    function signTypedData(string calldata jsonData, string calldata walletType, string calldata walletArgs)
        external pure returns (uint8 v, bytes32 r,bytes32 s);

would it solve your issues? note that u'd still have to enable the FFI flag

[aviggiano]

I think this solves my problem, thanks

[0xrusowsky]

@aviggiano unfortunately, the ledger support will have to wait a little bit more.

after discussing it with @zerosnacks and @grandizzy, we've agreed that my proposal is not optimal due to the inherent risks of executing FFI calls on the terminal (even if it's a call to cast in this case).

Instead, we will think how to come around the limitation that forces cheatcodes to be synchronous. However, this requires some design and exploration work.

[bowd]

Ah damn so the async part is the source of complexity here. I was also building something on top of @aviggiano 's lib and the ffi limitation screws with my usecase a bit more. I wanted to have the option of both signing and broadcasting from the ledger in the same script and that's currently not possible with this solution, because if forge connects to the ledger, the ffi call to cast won't run.

Any intution on how likely it would be to make async cheatcodes a reality?

[grandizzy]

going to close this one in favor of fix of #10986