Skip to content

Conversation

@grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Mar 24, 2025

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

# `platform` and `arch`: Used in tarball names
# `svm`: target platform to use for the Solc binary: https://github.com/roynalnaruto/svm-rs/blob/84cbe0ac705becabdc13168bae28a45ad2299749/svm-builds/build.rs#L4-L24
- runner: Linux-20.04
- runner: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use custom runner?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need a newer gclib to build the aws crate with, do you mean to use a custom 20.04 runner with such update?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean Linux-22.04, which should just be ubuntu-22.04 with better specs

Copy link
Collaborator Author

@grandizzy grandizzy Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, gotcha, when I prev attempted this somehow the Linux-22.04 label was selecting a ubuntu-24.04 runner which made released binaries to fail on 22.04...

See https://github.com/foundry-rs/foundry/actions/runs/13916454423/job/38940305881#step:1:2

Current runner version: '2.322.0'
Runner name: 'Linux-22.04_d4172d20eb25'
Runner group name: 'Foundry'
Machine name: 'runner'
Operating System
  Ubuntu
  24.04.2
  LTS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name of our custom paid runners.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah interesting!

cc @grandizzy https://github.com/foundry-rs/foundry/actions/runners indeed shows Linux-22.04 mapping to Ubuntu 24.04

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, gotcha, will change

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the runners in f6fde94 and runner specs was changed too

zerosnacks
zerosnacks previously approved these changes Mar 24, 2025
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@zerosnacks zerosnacks dismissed their stale review March 24, 2025 14:59

Outdated, we should updated the custom runners' mapping

@grandizzy grandizzy merged commit 84477c6 into cargo-update Mar 24, 2025
22 checks passed
@grandizzy grandizzy deleted the grandizzy/release-cargo-updates branch March 24, 2025 16:37
DaniPopes pushed a commit that referenced this pull request Mar 24, 2025
* chore(deps): weekly `cargo update`

     Locking 119 packages to latest compatible versions
    Updating alloy-chains v0.1.64 -> v0.1.66
    Updating alloy-consensus v0.12.4 -> v0.12.6
    Updating alloy-consensus-any v0.12.4 -> v0.12.6
    Updating alloy-contract v0.12.4 -> v0.12.6
    Updating alloy-dyn-abi v0.8.22 -> v0.8.24
    Updating alloy-eips v0.12.4 -> v0.12.6
    Updating alloy-genesis v0.12.4 -> v0.12.6
    Updating alloy-json-abi v0.8.22 -> v0.8.24
    Updating alloy-json-rpc v0.12.4 -> v0.12.6
    Updating alloy-network v0.12.4 -> v0.12.6
    Updating alloy-network-primitives v0.12.4 -> v0.12.6
    Updating alloy-primitives v0.8.22 -> v0.8.24
    Updating alloy-provider v0.12.4 -> v0.12.6
    Updating alloy-pubsub v0.12.4 -> v0.12.6
    Updating alloy-rpc-client v0.12.4 -> v0.12.6
    Updating alloy-rpc-types v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-anvil v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-any v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-debug v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-engine v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-eth v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-trace v0.12.4 -> v0.12.6
    Updating alloy-rpc-types-txpool v0.12.4 -> v0.12.6
    Updating alloy-serde v0.12.4 -> v0.12.6
    Updating alloy-signer v0.12.4 -> v0.12.6
    Updating alloy-signer-aws v0.12.4 -> v0.12.6
    Updating alloy-signer-gcp v0.12.4 -> v0.12.6
    Updating alloy-signer-ledger v0.12.4 -> v0.12.6
    Updating alloy-signer-local v0.12.4 -> v0.12.6
    Updating alloy-signer-trezor v0.12.4 -> v0.12.6
    Updating alloy-sol-macro v0.8.22 -> v0.8.24
    Updating alloy-sol-macro-expander v0.8.22 -> v0.8.24
    Updating alloy-sol-macro-input v0.8.22 -> v0.8.24
    Updating alloy-sol-type-parser v0.8.22 -> v0.8.24
    Updating alloy-sol-types v0.8.22 -> v0.8.24
    Updating alloy-transport v0.12.4 -> v0.12.6
    Updating alloy-transport-http v0.12.4 -> v0.12.6
    Updating alloy-transport-ipc v0.12.4 -> v0.12.6
    Updating alloy-transport-ws v0.12.4 -> v0.12.6
    Updating ariadne v0.5.0 -> v0.5.1
    Updating async-compression v0.4.20 -> v0.4.21
    Updating async-trait v0.1.87 -> v0.1.88
    Updating aws-config v1.5.18 -> v1.6.0
    Updating aws-credential-types v1.2.1 -> v1.2.2
      Adding aws-lc-rs v1.12.6
      Adding aws-lc-sys v0.27.1
    Updating aws-runtime v1.5.5 -> v1.5.6
    Updating aws-sdk-kms v1.62.0 -> v1.63.0
    Updating aws-sdk-sso v1.61.0 -> v1.62.0
    Updating aws-sdk-ssooidc v1.62.0 -> v1.63.0
    Updating aws-sdk-sts v1.62.0 -> v1.63.0
    Updating aws-sigv4 v1.2.9 -> v1.3.0
    Removing aws-smithy-http v0.60.12
    Removing aws-smithy-http v0.61.1
    Updating aws-types v1.3.5 -> v1.3.6
   Unchanged axum v0.7.9 (available: v0.8.1)
   Unchanged backtrace v0.3.71 (available: v0.3.74)
    Updating base64ct v1.7.1 -> v1.7.3
      Adding bindgen v0.69.5
    Updating bon v3.4.0 -> v3.5.1
    Updating bon-macros v3.4.0 -> v3.5.1
    Updating cc v1.2.16 -> v1.2.17
      Adding cexpr v0.6.0
      Adding clang-sys v1.8.1
    Updating clap_complete v4.5.46 -> v4.5.47
      Adding cmake v0.1.54
    Updating deranged v0.3.11 -> v0.4.0
    Updating foldhash v0.1.4 -> v0.1.5
    Updating foundry-block-explorers v0.11.0 -> v0.11.2
    Updating gcloud-sdk v0.26.3 -> v0.26.4
    Updating getrandom v0.3.1 -> v0.3.2
    Removing h2 v0.3.26
    Updating half v2.4.1 -> v2.5.0
    Updating handlebars v6.3.1 -> v6.3.2
    Updating http v1.2.0 -> v1.3.1
    Updating http-body-util v0.1.2 -> v0.1.3
    Updating humantime v2.1.0 -> v2.2.0
    Removing hyper v0.14.32
    Removing hyper-rustls v0.24.2
    Updating inferno v0.12.1 -> v0.12.2
      Adding itertools v0.12.1
      Adding jobserver v0.1.32
      Adding lazycell v1.3.0
    Updating libc v0.2.170 -> v0.2.171
      Adding libloading v0.8.6
    Updating linux-raw-sys v0.9.2 -> v0.9.3
      Adding macro-string v0.1.4
    Updating once_cell v1.21.0 -> v1.21.1
    Updating op-alloy-consensus v0.11.0 -> v0.11.2
    Updating op-alloy-rpc-types v0.11.0 -> v0.11.2
    Updating prettyplease v0.2.30 -> v0.2.31
    Updating prodash v29.0.0 -> v29.0.1
   Unchanged protobuf v3.3.0 (available: v3.7.2)
   Unchanged protobuf-support v3.3.0 (available: v3.7.2)
    Updating quinn v0.11.6 -> v0.11.7
    Updating quinn-proto v0.11.9 -> v0.11.10
    Updating quote v1.0.39 -> v1.0.40
      Adding r-efi v5.2.0
   Unchanged rand v0.8.5 (available: v0.9.0)
    Updating reqwest v0.12.12 -> v0.12.15
    Updating revm v19.6.0 -> v19.7.0
    Updating revm-precompile v16.1.0 -> v16.2.0
    Updating ring v0.17.13 -> v0.17.14
      Adding rustc-hash v1.1.0
    Updating rustix v1.0.2 -> v1.0.3
    Removing rustls v0.21.12
    Removing rustls v0.23.23
      Adding rustls v0.23.25
    Removing rustls-native-certs v0.6.3
    Removing rustls-pemfile v1.0.4
    Removing rustls-webpki v0.101.7
    Removing rustls-webpki v0.102.8
      Adding rustls-webpki v0.103.0
    Removing sct v0.7.1
    Removing security-framework v2.11.1
   Unchanged solang-parser v0.3.3 (available: v0.3.4)
    Updating svm-rs-builds v0.5.13 -> v0.5.14
    Updating syn-solidity v0.8.22 -> v0.8.24
    Updating tempfile v3.18.0 -> v3.19.1
    Updating time v0.3.39 -> v0.3.40
    Updating time-core v0.1.3 -> v0.1.4
    Updating time-macros v0.2.20 -> v0.2.21
    Updating tokio v1.44.0 -> v1.44.1
    Removing tokio-rustls v0.24.1
    Updating tokio-util v0.7.13 -> v0.7.14
      Adding tracing-futures v0.2.5
    Updating uuid v1.15.1 -> v1.16.0
   Unchanged vergen v8.3.2 (available: v9.0.4)
    Updating wasi v0.13.3+wasi-0.2.2 -> v0.14.2+wasi-0.2.4
      Adding which v4.4.2
    Updating widestring v1.1.0 -> v1.2.0
    Updating windows-interface v0.59.0 -> v0.59.1
    Updating windows-link v0.1.0 -> v0.1.1
    Updating windows-registry v0.2.0 -> v0.4.0
    Updating windows-result v0.3.1 -> v0.3.2
    Updating winnow v0.7.3 -> v0.7.4
    Updating wit-bindgen-rt v0.33.0 -> v0.39.0
    Updating zerocopy v0.8.23 -> v0.8.24
    Updating zerocopy-derive v0.8.23 -> v0.8.24
    Updating zip v2.4.1 -> v2.4.2
note: to see how you depend on a package, run `cargo tree --invert --package <dep>@<ver>`

* chore: release for latest cargo updates (#10168)

* update release for new cargo update

* Use Linux-22.04

---------

Co-authored-by: mattsse <[email protected]>
Co-authored-by: grandizzy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants