fix: invalidate cache for out-of-scope entries#104
Merged
Conversation
mattsse
approved these changes
Apr 17, 2024
Member
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
nice,
triggering patch once merged
Comment on lines
+729
to
+730
| // Build a temporary graph to repeat the process above. We need this because `self.edges` | ||
| // only contains graph data for in-scope sources. |
mattsse
pushed a commit
that referenced
this pull request
Apr 17, 2024
Follow-up to #104. Right now we detect and remove dirty cache entries in `ArtifactsCacheInner::filter` which is redundant as we can just do a single iteration over all cached files. Now file filtering is done in 2 steps: 1. `ArtifactsCacheInner::find_and_remove_dirty` detects all dirty entries (even those that are not in scope of current compiler run) and removes them from cache. 2. `ArtifactsCacheInner::filter` schedules for compilation all sources for which we are missing artifacts (either because of removed entry or because we never compiled given source with current version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
missed this in #90
ref https://t.me/foundry_support/52331
after #90 we stopped removing out of scope sources from cache, however, we never validated if they are dirty, this results in invalid cached artifacts in certain cases.
with this PR we iterate over all cache entries out of scope of current compiler run, then build graph with them to find if they import any of files marked as dirty.