Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible solution for #8257 #8318

Merged
merged 3 commits into from
Mar 15, 2016
Merged

Conversation

DaSchTour
Copy link
Contributor

taking first breakpoint and check if smallest and define it as zero-breakpoint

taking first breakpoint and check if smallest and define it as zero-breakpoint
@gakimball
Copy link
Contributor

Thanks for putting this together! My feedback:

  • Name the variable $-zf-zero-breakpoint. The prefix emphasizes that it's a private variable—we don't need developers using it in their own code.
  • You'll need to replace every instance of @include breakpoint(small) in the framework with @include breakpoint($-zf-zero-breakpoint), so that if someone renames small in their breakpoint list, all of the internals of the framework are able to switch over to the new name.

@DaSchTour
Copy link
Contributor Author

Thanks for the feedback. I hoped I already found all references to small, but I'll check again. I'll make the changes as soon as possible.

@DaSchTour
Copy link
Contributor Author

I change the variable following your feedback and replaced all usages of small breakpoint. I wasn't 100% sure about one place. It's _rows.scss:83

@DaSchTour
Copy link
Contributor Author

Is there anything more to do?

@gakimball
Copy link
Contributor

Nope, looks good. Thanks for putting it together!

gakimball added a commit that referenced this pull request Mar 15, 2016
@gakimball gakimball merged commit 21b75ad into foundation:develop Mar 15, 2016
@proimage
Copy link

So what's the quick-and-dirty guide to implementing this change in our bleeding-edge code? Do we just add something like this to settings.scss:

$-zf-zero-breakpoint: 'small'; // or 'xsmall' or 'tiny' or 'smallest' or whatever

@DaSchTour DaSchTour deleted the dev/8257 branch March 16, 2016 15:32
@gakimball
Copy link
Contributor

@proimage That will probably work. Edit: well, if you're already pulling in the develop branch, then you'll have the change anyway.

@proimage
Copy link

Thou assumest too muchly - I roll Foundation SCSS manually. :p

For the record, yes, after downloading the latest develop branch and using the scss folder therein, adding that one line above to my settings.scss appears to have brought things back to the way they were in 6.1.x. Much grass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants