Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable and disable scroll if there is no visible reveal #11705

Merged
merged 1 commit into from Aug 12, 2019
Merged

fix: enable and disable scroll if there is no visible reveal #11705

merged 1 commit into from Aug 12, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Feb 28, 2019 •
edited
Loading

Description

...

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@DanielRuf DanielRuf mentioned this pull request Feb 28, 2019
Closed
3 tasks
kolejakjozef
kolejakjozef approved these changes Feb 28, 2019
View reviewed changes
Copy link

@kolejakjozef kolejakjozef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, works like expected now.

@DanielRuf DanielRuf requested a review from ncoden March 1, 2019 08:27
@kball kball merged commit f77a4bc into foundation:develop Aug 12, 2019
@DanielRuf DanielRuf deleted the fix/11704-reveal-enable-disable-scroll-visible branch August 12, 2019 22:04
@joeworkman
Copy link
Member

This pull request has been mentioned on Foundation Open Source Community. There might be relevant details there:

https://foundation.discourse.group/t/foundation-for-sites-v6-6-0-is-here-farout/30/1

This was referenced Mar 10, 2020
Closed
Closed
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolejakjozef kolejakjozef kolejakjozef approved these changes

@kball kball kball approved these changes

@ncoden ncoden Awaiting requested review from ncoden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reveal multiple opened: body scrolls top
4 participants
@DanielRuf @joeworkman @kball @kolejakjozef