Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test Node.js 6, 8, 10 and stable #11561

Merged
merged 2 commits into from Oct 25, 2018
Merged

ci: test Node.js 6, 8, 10 and stable #11561

merged 2 commits into from Oct 25, 2018

Conversation

DanielRuf
Copy link
Contributor

Description

Explicitely test Node.js 6, 8, 10 and stable (11).

  • Closes

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

ncoden
ncoden approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielRuf 👍

@ncoden ncoden merged commit fedf7e2 into foundation:develop Oct 25, 2018
@DanielRuf DanielRuf deleted the ci/test-nodejs-6-8-10-stable branch October 25, 2018 19:25
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Oct 29, 2018
@ncoden
Use pull request foundation#11561 from DanielRuf/ci/test-nodejs-6-8-1…
7449041 
…0-stable for v6.5.0

cb38e03 ci: test Node.js 6, 8, 10 and stable

Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
💻 maintenance 🚨tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden