docs: make Callout closable in the first Close Button example #11549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People could get confused with the example showing a close button that have not effect. This commit makes the Callout closable in the first Close Button example.
ncoden
added a commit
that referenced
this pull request
Oct 21, 2018
…-example for v6.5.0 7cffc52 docs: make Callout closable in the first Close Button example Signed-off-by: Nicolas Coden <[email protected]>
ncoden
added a commit
that referenced
this pull request
Oct 21, 2018
…-example for v6.5.0 7cffc52 docs: make Callout closable in the first Close Button example Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
People could get confused with the example showing a close button that have not effect.
Changes
Types of changes
Checklist
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).