Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix plugins instantiation examples in Javascript docs #11545

Merged

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Oct 18, 2018

Description

Instansiate plugins with jQuery elements $('selector') instead of a simple selector in examples of the Javascript documentation.

See discussion in #11508

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

Copy link
Contributor

@SassNinja SassNinja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@ncoden ncoden merged commit afe4330 into foundation:develop Oct 19, 2018
ncoden added a commit that referenced this pull request Oct 21, 2018
…ion-element for v6.5.0

3a07965 docs: fix plugins instantiation examples in Javascript docs

Signed-off-by: Nicolas Coden <[email protected]>
ncoden added a commit that referenced this pull request Oct 21, 2018
…ion-element for v6.5.0

3a07965 docs: fix plugins instantiation examples in Javascript docs

Signed-off-by: Nicolas Coden <[email protected]>
@ncoden ncoden mentioned this pull request Oct 21, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants