fix: lower breakpoint max value precision to avoid rounding #11313 #11315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n#11313 As seen in foundation#10978, we need a subpixel precision to handle zoomed browsers. But browsers handle sub-pixel mediaqueries badly and a too high precision causes the issue described above. So we have to find the proper balance for a maximum support. Changes: * set breakpoint max values to `0.00125em` (`0.02px`) under the next breakpoint instead of `0.00001`. Closes foundation#11313
DanielRuf
reviewed
May 31, 2018
scss/_global.scss
Outdated
| @@ -105,7 +105,7 @@ $global-text-direction: ltr !default; | |||
|
|
|||
| /// Enables flexbox for components that support it. | |||
| /// @type Boolean | |||
| $global-flexbox: true !default; | |||
| $global-flexbox: false !default; | |||
There was a problem hiding this comment.
For testing on IE. I forgot it.
DanielRuf
approved these changes
May 31, 2018
|
Thank you for the review @DanielRuf |
4 tasks
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…h-precision-11313 for v6.5.0 798377d fix: lower breakpoint max value precision to avoid rounding foundation#11313 a36504c fix: revert mistakenly changed `$global-flexbox` setting in foundation#11315 Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As seen in #10978, we need a subpixel precision to handle zoomed browsers. But browsers handle sub-pixel mediaqueries badly and a too high precision causes the issue described above. So we have to find the proper balance for a maximum support.
Changes:
0.00125em(0.02px) under the next breakpoint instead of0.00001.Closes #11313
Types of changes
functionality to change)
Checklist (all required):
developorsupport/*).