fix: use fallback gutter for fallback breakpoint in XY cell #11194 #11300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When no breakpoint is passed to
xy-cell
and a fallback "zero" breakpoint is used, use a fallback gutter as well if it is not found. This way, an implicit behavior stay implicit and a warning is thrown only if a breakpoint was explicitely given.The following code:
Now generate (instead of throwing a warning):
Closes #11194
Motivation and Context
Breakpoint could be added to
$breakpoints
while$grid-margin-gutters
is left unchanged. A custom zero breakpoint likexsmall
can be added beforesmall
. In this case,@include xy-cell(12);
will fail becausexy-cell
will search for a gutter value forxsmall
.As
xy-cell
fallback toxsmall
implicitly, I expect all values direved from it to also have a fallback, unless we require a zero-breakpoint value to be declared in all breakpoint-related values.Screenshots (if appropriate):
Types of changes
functionality to change)
Checklist (all required):
develop
orsupport/*
).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).