Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify usage of body overflow in XY Grid grid-frame example #11280

Merged
merged 1 commit into from
May 18, 2018
Merged

docs: clarify usage of body overflow in XY Grid grid-frame example #11280

merged 1 commit into from
May 18, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 18, 2018 •
edited
Loading

Based on #11273 [DOCS] Clarify usage of body overflow hiding re .medium-grid-frame example in docs opened by @paxperscientiam. The original pull request was based on zurb:master.

Description

Per PR #11191 and my own comment, I have added commentary warning re hiding body overflow.

Motivation and Context

My motivation is to help others that may or may have blindly add body{overflow:hidden;} to their code per current suggestion and wind up with a webpage that won't scroll on small screens.

Hope that makes sense!

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

@ncoden ncoden requested a review from DanielRuf May 18, 2018 21:10
@ncoden ncoden mentioned this pull request May 18, 2018
Closed
10 tasks
@ncoden ncoden merged commit cfbf5a4 into foundation:develop May 18, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@paxperscientiam @ncoden
Use pull request foundation#11280 from ncoden/docs/clarify-xy-grid-fr…
4ff433b 
…ame-example for v6.5.0

887b83f docs: clarify usage of body overflow in XY Grid grid-frame example

Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
📖 documentation XY Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncoden @DanielRuf @paxperscientiam