Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form progress bar mixin calls has-value as hasvalue #11250

Merged
merged 1 commit into from
May 12, 2018
Merged

fix: form progress bar mixin calls has-value as hasvalue #11250

merged 1 commit into from
May 12, 2018

Conversation

datatypevoid
Copy link

@datatypevoid datatypevoid commented May 11, 2018 •
edited
Loading

Description

Was reading through source and noticed that the method calls seemed to be missing dashes.

  • Closes

Motivation and Context

Fixes incorrect method calls.

Screenshots (if appropriate):

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

ncoden
ncoden reviewed May 11, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @datatypevoid, thank you for your PR!

So I guess that $progress-radius didn't have any effect. I'll check that before merging.

@DanielRuf DanielRuf self-requested a review May 11, 2018 21:33
@DanielRuf
Copy link
Contributor

@ncoden see https://github.com/zurb/foundation-sites/blob/develop/scss/util/_value.scss#L14

@ncoden ncoden merged commit 52ba3b1 into foundation:develop May 12, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11250 from datatypevoid/fix-form-progress…
980e7c0 
…-bar-mixin for v6.5.0

acaa2a7 fix: form progress bar mixin calls `has-value` as `hasvalue`

Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden left review comments

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
bug fix Progress Bar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datatypevoid @DanielRuf @ncoden