fix: fix uncentered last column on Float Grid #9952 #11115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le float position Handle all the float positioning of Float Grid in the same mixin. This also makes the "last column" selector used only in this mixin.
Ensure to uncenter the last column with the right specificity even when `$grid-column-align-edge` is disabled.
|
Will test later that day. |
|
Thanks for the review. |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…ed-last-column-9952 for v6.5.0 50e7dab fix: fix uncenter for last column in Float Grid foundation#9952 fa07c03 refactor: add "default" position to `grid-column-positioning` to handle float position 9429539 tests: add visual test for Float Grid uncentered columns a8f850e fix: fix last column uncentering with edge align disabled in Float Grid Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
$grid-column-align-edge) when uncentered.@mixin grid-column-positionto handle all the float positioning and the last column hack in the same place.Closes #9952