Skip to content

chore: temporary disable UMD bundling #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2018
Merged

chore: temporary disable UMD bundling #10911

merged 3 commits into from
Feb 4, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented Feb 4, 2018

⚠️ This is not breaking anything, since UMD bundling was not released yet, but this must be resolved before the next release.

So develop is broken because I am too stupid to test correctly a PR before merging it. --'
Also, the problem in this issue is:

  1. Webpack transpilation to UMD require a particular format for externals (see https://webpack.js.org/configuration/output/#module-definition-systems).
  2. Exports in Foundation plugins are "named" (and not defaults), so importing them as external require to make external targets objects (in which we can pick up the named plugin). (see abfd426)
  3. External format for UMD does not support the "object target".
    Temporary disable UMD bundling, waiting for a way to import plugins are externals

Bug introduced in #10864
Part of #10903

ncoden added 3 commits February 4, 2018 01:25
@ncoden
fix: export Foundation in foundation.core entry for usage in other …
c2acd0c 
…entries
@ncoden
fix: fix Object.assign usage in javascript:plugins gulp task
fe895f5
@ncoden
fix: temporary disable UMD bundling
568a9a5 
⚠️ this must be resolved before the next release

Temporary disable UMD bundling, waiting for a way to import plugins are externals

See foundation#10903
@ncoden ncoden added this to the 6.4.4 milestone Feb 4, 2018
@ncoden ncoden mentioned this pull request Feb 4, 2018
Closed
@ncoden ncoden merged commit f3d375f into foundation:develop Feb 4, 2018
This was referenced Feb 4, 2018
Closed
Merged
@ncoden ncoden deleted the fix/temporary-disable-umd-bundling branch April 7, 2018 17:46
ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#10911 from ncoden/fix/temporary-disable-u…
2fd195d 
…md-bundling for v6.5.0

c2acd0c fix: export Foundation in `foundation.core` entry for usage in other entries
fe895f5 fix: fix `Object.assign` usage in `javascript:plugins` gulp task
568a9a5 fix: temporary disable UMD bundling

Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🚚 build
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ncoden