fix: prevent "space" on input to open dropdown #10715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncoden
reviewed
Dec 24, 2017
js/foundation.dropdown.js
Outdated
| @@ -178,7 +178,7 @@ class Dropdown extends Positionable { | |||
|
|
|||
| Keyboard.handleKey(e, 'Dropdown', { | |||
| open: function() { | |||
| if ($target.is(_this.$anchors)) { | |||
| if ($target.is(_this.$anchors) && !$target.is('input')) { | |||
There was a problem hiding this comment.
Not only input should be able to get a space without losing the focus. I think we have two solutions:
- determine all the native elements that should be able to receive
spaceand make a big filter - add an option to the
dropdownelement to prevent the keyboard catching
ncoden
changed the title
ncoden
approved these changes
Jan 31, 2018
|
Good finding with the |
|
Why |
4 tasks
|
Sorry, I just realized now that I was in a different context. you are correct. |
|
See: #10899 (including new feature to control the keyboard on Dropdown), based on this PR. |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Jun 16, 2018
…r v6.5.0 848e9c0 Added visual test for a Dropdown attached to an input element. 2d736a1 Prevent SPACE from setting focus to the Dropdown if anchor is an input element. 87c3d4f Added unittest for keyboard events for Dropdown. 64e5ede feat: ignore dropdown keyboard event on textarea Co-Authored-By: Nicolas Coden <[email protected]> Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the usecase where I used a Dropdown as a auto-completion/suggestion feature. The Dropdown was attached to an input element and shows when the input has focus. Issue was then, that everytime a space was entered into the input, the Dropdown would receive focus and prevent the typing within the input.
I am not sure, whether this is too specific or not to become part of the code base.