Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add height pinning to cell-block-y #10649

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add height pinning to cell-block-y #10649

merged 1 commit into from
Sep 25, 2017

Conversation

kball
Copy link
Contributor

@kball kball commented Sep 14, 2017

Fixes #10457

IamManchanda
IamManchanda approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@IamManchanda IamManchanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafibomb rafibomb merged commit 70eae11 into develop Sep 25, 2017
@kball
Copy link
Contributor Author

kball commented Oct 5, 2017

This introduced a bug in Safari, turned up in QA. I believe using min-height:100% will have the same impact, and does not appear to introduce the same bug. Any reasons I'm missing why height pinning using min-height wouldn't work? (CC @oxyc @brgrz as the folks who were involved in #10457)

@kball kball mentioned this pull request Oct 5, 2017
Closed
@colin-marshall colin-marshall deleted the set-cell-block-y-to-max-height branch January 19, 2018 17:58
@colin-marshall colin-marshall mentioned this pull request Mar 7, 2018
Closed
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamManchanda IamManchanda IamManchanda approved these changes

Assignees
No one assigned
Labels
XY Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kball @IamManchanda @DaSchTour @rafibomb