Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset for y-grid to clear max-width as well #10648

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

kball
Copy link
Contributor

@kball kball commented Sep 14, 2017

Fixes issue where grid-y cells are still constrained by the width set by grid-x cells.

Fixes
xy grid foundation for sites 6 docs

To
xy grid foundation for sites 6 docs-1

@rafibomb
Copy link
Member

I see the docs does that but not in a 6.4.3 codepen https://codepen.io/rafibomb/pen/yzgXZm
In the CSS it looks like width is reset properly
screen shot 2017-09-25 at 2 19 34 pm

@rafibomb rafibomb self-assigned this Sep 25, 2017
@kball
Copy link
Contributor Author

kball commented Oct 3, 2017

Digging into this further, the situation occurs when you have both the xy grid and the traditional flex-grid in the page. The XY grid is much more careful about specificity than the traditional grid... that said, this is intended to be a supported case, so i'd like the reset to work.

@rafibomb rafibomb merged commit 8297498 into develop Oct 3, 2017
@rafibomb
Copy link
Member

rafibomb commented Oct 3, 2017

That's what it is - makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants