Xy grid frame fix for margin grids #10448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes: Will look into it tomm! |
|
Well I’m not sure the suggested solution (https://codepen.io/brettsmason/pen/LLBoNB) really works. I can still see some margin at the bottom. |
|
@OndrejVasicek That CodePen is slightly different to the PR. The PR adds a full amount of gutter to the height calculation. The only requirement for this to work is overflow on the body needs to be hidden, but I've added a note to the docs about this. From my testing and review this works great so I'm going to merge, thanks for the help on this as always @kball 😄 👍 |
kball
pushed a commit
that referenced
this pull request
Jul 25, 2017
Xy grid frame fix for margin grids
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10305
@OndrejVasicek as the original filer of the issue, could you take a look?
cc @IamManchanda @brettsmason