Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell should always emit gutters if -output is enabled #10437

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

kball
Copy link
Contributor

@kball kball commented Jul 19, 2017

Fixes #10387 based on my assessment of the situation in #10387 (comment)

@brettsmason please review.

@kball kball requested a review from brettsmason July 19, 2017 22:34
@brettsmason
Copy link
Contributor

@kball This looks good. Your comment about the mixin does indeed make sense and I think is the correct way to go. I've tested this locally and is fine so going to merge.

@brettsmason brettsmason merged commit 9c95f56 into develop Jul 20, 2017
kball pushed a commit that referenced this pull request Jul 25, 2017
Cell should always emit gutters if -output is enabled
@colin-marshall colin-marshall deleted the IS10387-xy-cell-mixin branch January 19, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants