Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing . with class names with xy grid #10370

Merged
merged 1 commit into from
Jul 21, 2017

Conversation

brettsmason
Copy link
Contributor

Noticed a bug when reworking grid container that a lot of the base classes (without margin/padding) were missing . in their class names and as a result weren't working.

Noticed a bug when reworking grid container that a lot of the base classes (without margin/padding) were missing `.` in their class names and as a result weren't working.
@brettsmason brettsmason changed the title Fix missing . with class names Fix missing . with class names with xy grid Jul 17, 2017
Copy link
Contributor

@IamManchanda IamManchanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IamManchanda
Copy link
Contributor

LGTM... cc @kball for merge/review!

@kball kball merged commit 6031a3d into develop Jul 21, 2017
kball added a commit that referenced this pull request Jul 25, 2017
Fix missing `.` with class names with xy grid
@colin-marshall colin-marshall deleted the brettsmason-fix-grid-base-classes branch January 19, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants