-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs: Browser back doesn't take us back to default tab #11100
Comments
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this issue
Aug 26, 2018
…oundation#11100 When deep-linking is enabled and the user goes back in the history up to when no hash is set, display the initially-selected content/tab instead of staying with the content/tab that was selected the first. Closes foundation#11100 Replaces foundation#11101
9 tasks
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this issue
Aug 26, 2018
…oundation#11100 When deep-linking is enabled and the user goes back in the history up to when no hash is set, display the initially-selected content/tab instead of staying with the content/tab that was selected the first. Closes foundation#11100 Replaces foundation#11101 Co-authored-by: Jamie Chong <[email protected]>
ncoden
added a commit
that referenced
this issue
Sep 12, 2018
fix: return to initial state when reseting hash in Accordion & Tabs #11100
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this issue
Sep 12, 2018
…nking-11100 for v6.5.0 5ea51f3 fix: return to initial state when reseting hash in Accordion & Tabs foundation#11100 314b4ee fix: fix initial state for Accordion without any panel active abbbdbf refactor: split DOM operations from logics in Accordion e261905 refactor: move "init only" Accordion logic to its own methods b819faf docs: remove outdated comments in Accordion related to the initial state 7307c43 feat: add "Tabs._collapse()" to collapse the active tab 012db10 refactor: clean up the Tab initialization c6d37c4 fix: close the active Tab when going back to a "tab-less" history state 2673567 docs: fix "zplugin" typo in Accordion & Tabs events Signed-off-by: Nicolas Coden <[email protected]>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
How to reproduce this bug:
data-deep-link="true"
anddata-update-history="true"
. The 2nd option pushes state onto the browser history.The hash changes as you click the tabs. When clicking back the state reverses and the previous tab loads accordingly. However, when getting back to the original URL, the tab state doesn't update.
Browser(s) and Device(s) tested on:
Desktop Chrome
Foundation Version(s) you are using:
6.4.3
Test case link:
https://codepen.io/anon/pen/LdeRmW
The text was updated successfully, but these errors were encountered: