Skip to content

Commit

Permalink
Merge pull request #11145 from DanielRuf/fix/block-grid-breakpoints-m…
Browse files Browse the repository at this point in the history
…argins-11121

fix: use the right breakpoints in block-grid for gutter calculation
  • Loading branch information
ncoden authored Apr 10, 2018
2 parents 98591d9 + f542435 commit 9aef331
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions scss/xy-grid/_classes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@
@include -zf-each-breakpoint {
@for $i from 1 through $xy-block-grid-max {
.#{$-zf-size}-up-#{$i} {
@include xy-grid-layout($i, '.cell', false, $gutter-type: padding);
@include xy-grid-layout($n: $i, $selector: '.cell', $gutter-output: false, $gutter-type: padding, $breakpoint: $-zf-size);
}
}
}
Expand All @@ -203,15 +203,15 @@
@each $bp in -zf-breakpoints-less-than($-zf-size) {
@if(map-has-key($grid-margin-gutters, $bp)) {
.grid-margin-x.#{$bp}-up-#{$i} {
@include xy-grid-layout($i, '.cell', false, $gutter-type: margin, $breakpoint: $bp);
@include xy-grid-layout($n: $i, $selector: '.cell', $gutter-output: false, $gutter-type: margin, $breakpoint: $-zf-size);
}
}
}
}
}
@for $i from 1 through $xy-block-grid-max {
.grid-margin-x.#{$-zf-size}-up-#{$i} {
@include xy-grid-layout($i, '.cell', false, $gutter-type: margin, $breakpoint: $-zf-size);
@include xy-grid-layout($n: $i, $selector: '.cell', $gutter-output: false, $gutter-type: margin, $breakpoint: $-zf-size);
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion scss/xy-grid/_layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
/// @param {Number|Map} $gutters [$grid-margin-gutters] - Map or single value for gutters.
/// @param {Keyword} $gutter-type [margin] - Type of gutter to output. Accepts `margin` or `padding`.
/// @param {List} $gutter-position [right left] - The position to apply gutters to. Accepts `top`, `bottom`, `left`, `right` in any combination.
/// @param {String} $breakpoint [null] - The breakpoint to use for the cell generation.
/// @param {Boolean} $vertical [false] - Set to true to output vertical (height) styles rather than widths.
@mixin xy-grid-layout(
$n,
Expand All @@ -22,7 +23,7 @@
$gutters: $grid-margin-gutters,
$gutter-type: margin,
$gutter-position: right left,
$breakpoint: $-zf-zero-breakpoint,
$breakpoint: null,
$vertical: false
) {
$size: percentage(1/$n);
Expand Down

0 comments on commit 9aef331

Please sign in to comment.