release: merge set of changes for v1.2.0 by willmj · Pull Request #299 · foundation-model-stack/fms-hf-tuning

willmj · 2024-08-14T18:44:00Z

Description of the change

v1.2.0 release

Related issue number

How to verify the PR

Was the PR tested

I have added >=1 unit test(s) for every new method I have added.
I have ensured all unit tests pass

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

…thon logger Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

* initial code for deleting lm_head Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fix logic for copying checkpoint Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fix check that embed_tokens and lm_head weights are the same Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fix warning assertion Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fix lm_head check, remove test Signed-off-by: Anh-Uong <anh.uong@ibm.com> * small fixes from code review Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fmt Signed-off-by: Anh-Uong <anh.uong@ibm.com> --------- Signed-off-by: Anh-Uong <anh.uong@ibm.com> Co-authored-by: Anh-Uong <anh.uong@ibm.com> Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Add config_utils tests

* feat: On save event added to callback Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Removed additional bracket Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Removed additional bracket Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Format issues resolved Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: rebase with upstream and add new line Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com> --------- Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com> Co-authored-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>

* feat: All metric handling changes Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Format issues Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> --------- Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

* feat: Added the triggered login in the operation Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Formatting issues Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Added default config Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Moved the variable to right scope Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Checked added to validate config log level Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Removed some unwanted log file Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> --------- Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

* refactor code to preprocess datasets Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * fix formatting Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * allow input/output in validate args Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * format input/output JSON and mask Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * function to return suitable collator Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * add tests for SFT Trainer input/output format Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * remove unused functions Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com> Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * add eos token to input/output format Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * fix tests Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * improve docstrings Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * keeping JSON keys constant Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * support for input/output format Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * formatting fixes Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * update rEADME formats Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> * formatting README Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> --------- Signed-off-by: Sukriti-Sharma4 <sukriti.sharma4@ibm.com> Co-authored-by: Alex-Brooks <Alex.Brooks@ibm.com>

This reverts commit f57ff63. Signed-off-by: Anh-Uong <anh.uong@ibm.com>

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

* Add a dockerfile argument at the end of final layer to enable aimstack. Currenlty guarded by a dockerfile argument. Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com> * Set the default value of ENABLE_AIM to false Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com> --------- Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

* Add unit test to verify target_modules defaults correctly Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * Add sft_trainer.main test to ensure target modules properly default for LoRA when set to None from CLI Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * fmt Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * Use model_args instead of importing, fix nits Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * Add test to ensure target_modules defaults to None in job config Signed-off-by: Will Johnson <mwjohnson728@gmail.com> * Add additional check, fix nits Signed-off-by: Will Johnson <mwjohnson728@gmail.com> --------- Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

…e. (#290) Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Fix: Removal of transformers logger and addition of python native logger

…p, on_substep_end (#293) Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

Signed-off-by: James Busche <jbusche@us.ibm.com> Co-authored-by: Anh Uong <anh.uong@ibm.com>

Signed-off-by: Will Johnson <mwjohnson728@gmail.com> Co-authored-by: Anh Uong <anh.uong@ibm.com>

* add save_model_dir flag for final checkpoint Signed-off-by: Anh-Uong <anh.uong@ibm.com> * remove output_dir logic, add save method Signed-off-by: Anh-Uong <anh.uong@ibm.com> * update accelerate_launch, remove save tokenizer Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fix: put back creation of .complete file Signed-off-by: Anh-Uong <anh.uong@ibm.com> * fix failing tests and add new ones Signed-off-by: Anh-Uong <anh.uong@ibm.com> * tests: add sft_trainer test to train and save - small refactor of tests Signed-off-by: Anh-Uong <anh.uong@ibm.com> * add docs on saving checkpoints and fix help msg Signed-off-by: Anh-Uong <anh.uong@ibm.com> * update example and note best checkpoint Signed-off-by: Anh-Uong <anh.uong@ibm.com> * changes based on PR review Signed-off-by: Anh-Uong <anh.uong@ibm.com> * add logging to save, fix error out properly Signed-off-by: Anh-Uong <anh.uong@ibm.com> --------- Signed-off-by: Anh-Uong <anh.uong@ibm.com>

anhuong · 2024-08-14T21:03:37Z

@willmj I looked through all of the commits and they look good except for the most recent commit from you. This does not look to be signed,

Merge tag 'v1.2.0-rc.1' into release

Some of the PRs that were done via merge commit instead of squash commit also have lots of commits spread out which makes it harder to read. So we should do squash commits going forward.

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

willmj and others added 30 commits July 29, 2024 09:52

Set default value of target_modules to be None in LoraConfig

ae1625b

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

Removal of transformers logger and addition of python logger

2b4ce8d

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

FMT and lint check: Removal of transformers logger and addition of py…

76fffc5

…thon logger Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Merge branch 'main' into fix_logging

2e36147

Add config_utils tests

a8bd8dd

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Fix fmt

7054070

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Separate tests out and use docstrings

906ce02

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Update more field/value checks from HF defaults

3e831c6

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Fix: Addition of env var TRANSFORMERS_VERBOSITY check

8846bc2

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

FMT Fix: Addition of env var TRANSFORMERS_VERBOSITY check

4ed3878

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Add test for tokenizer in lora config (should be ignored)

dc32eda

Signed-off-by: Angel Luu <angel.luu@us.ibm.com>

Adding logging support to accelerate launch

efb8363

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

FMT_FIX: Adding logging support to accelerate launch

2ecfaf7

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Merge pull request #262 from aluu317/test_config_utils

a9b8ec8

Add config_utils tests

Merge branch 'main' into fix_logging

f2e8afb

feat: All metric handling changes (#263)

71c3e8a

* feat: All metric handling changes Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> * fix: Format issues Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com> --------- Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

Merge branch 'main' into 1143

0bf6871

Merge branch 'main' into fix_logging

c44b1dc

limit peft deps until investigate (#274)

f57ff63

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

Revert "limit peft deps until investigate (#274)" (#275)

c7589d1

This reverts commit f57ff63. Signed-off-by: Anh-Uong <anh.uong@ibm.com>

feat: per process state metric (#239)

1884f61

Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>

Modify test to pass with target_modules: None

a09f837

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

Merge branch 'main' into 1143

c15f4f9

Merge branch 'foundation-model-stack:main' into fix_logging

abd8abc

Logging changes and unit tests added

5d08efb

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

willmj and others added 21 commits August 6, 2024 17:47

docs: Add documentation on experiment tracking. (#257)

d224be6

Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

Ensure additional metadata to trackers don't throw error in happy cas…

baeecf1

…e. (#290) Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

Merge remote-tracking branch 'upstream/main'

f0fcfdb

Merge branch 'main' into fix_logging

e65cb2d

PR Changes

4841119

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

fix multiple runid creation bug with accelerate. (#268)

0a9d4a6

Signed-off-by: Dushyant Behl <dushyantbehl@users.noreply.github.com>

feat: logging control operation (#264)

ce965a8

Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

Merge remote-tracking branch 'upstream/main'

fe8bb05

Metrics file epoch indexing from 0

5ecf4dd

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Revert last commit

89124ac

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

fix run evaluation to get base model path (#273)

bb0caf9

Signed-off-by: Anh-Uong <anh.uong@ibm.com>

Merge remote-tracking branch 'upstream/main'

bddad06

Merge branch 'main' into fix_logging

0777460

PR Changes

3068f51

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

PR Changes

0866bce

Signed-off-by: Abhishek <maurya.abhishek@ibm.com>

Merge pull request #270 from Abhishek-TAMU/fix_logging

ee25de4

Fix: Removal of transformers logger and addition of python native logger

feat: Added additional events such as on_step_begin, on_optimizer_ste…

a40e138

…p, on_substep_end (#293) Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>

Always update setuptools to latest (#288)

6e7cea6

Signed-off-by: James Busche <jbusche@us.ibm.com> Co-authored-by: Anh Uong <anh.uong@ibm.com>

Rename all fixtures with correct .jsonl extension (#295)

0aae2aa

Signed-off-by: Will Johnson <mwjohnson728@gmail.com> Co-authored-by: Anh Uong <anh.uong@ibm.com>

willmj requested review from Ssukriti, alex-jw-brooks and anhuong as code owners August 14, 2024 18:44

anhuong changed the title ~~v1.2.0 rc1~~ release: merge set of changes for v1.2.0 Aug 14, 2024

willmj force-pushed the v1.2.0-rc1 branch from f309821 to 0aae2aa Compare August 14, 2024 21:38

Merge tag 'v1.2.0-rc.1' into v1.2.0-rc1

6bcdf59

Signed-off-by: Will Johnson <mwjohnson728@gmail.com>

anhuong approved these changes Aug 14, 2024

View reviewed changes

anhuong merged commit 49305ad into release Aug 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

release: merge set of changes for v1.2.0#299

release: merge set of changes for v1.2.0#299
anhuong merged 79 commits intoreleasefrom
v1.2.0-rc1

willmj commented Aug 14, 2024 •

edited by anhuong

Loading

Uh oh!

anhuong commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Comments

Conversation

willmj commented Aug 14, 2024 • edited by anhuong Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of the change

Related issue number

How to verify the PR

Was the PR tested

Uh oh!

anhuong commented Aug 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

willmj commented Aug 14, 2024 •

edited by anhuong

Loading