feat: Example log controller yaml with training state#296
Merged
ashokponkumar merged 4 commits intofoundation-model-stack:mainfrom Aug 14, 2024
Merged
Conversation
seshapad
force-pushed
the
example_logging_control
branch
from
556b9d5 to
b873129
Compare
ashokponkumar
requested changes
Aug 12, 2024
| class: LogControl | ||
| arguments: | ||
| log_format: | | ||
| Saving model in huggingface format at samples_seen: {trainer_state[global_step]} |
Collaborator
There was a problem hiding this comment.
Suggested change
| Saving model in huggingface format at samples_seen: {trainer_state[global_step]} | |
| Saving model in huggingface format at samples_seen: {trainer_state[global_step]} |
It should not be samples_seen, its on a step, isn't it?
Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>
Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>
Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>
Signed-off-by: Padmanabha V Seshadri <seshapad@in.ibm.com>
seshapad
force-pushed
the
example_logging_control
branch
from
742e6a4 to
53764d1
Compare
ashokponkumar
approved these changes
Aug 14, 2024
ashokponkumar
requested review from
Ssukriti,
alex-jw-brooks and
anhuong
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR introduces a more involved example for log controller which uses multiple trainer controller metrics.
Related issue number
Closes #264
How to verify the PR
Was the PR tested