deps: pull in transformers latest version#235
Closed
anhuong wants to merge 3 commits intofoundation-model-stack:mainfrom
Closed
deps: pull in transformers latest version#235anhuong wants to merge 3 commits intofoundation-model-stack:mainfrom
anhuong wants to merge 3 commits intofoundation-model-stack:mainfrom
Conversation
Signed-off-by: Anh-Uong <anh.uong@ibm.com>
Collaborator
Author
|
Note that transformers starting with v4.42.0 unit tests fail when running inference with error Whereas transformers v4.41.2 unit tests succeeds. Also found related issue from transformers repo which is closed but has new comments with people hitting the same issue but is talking about an older version of transformers v4.38 |
Signed-off-by: Abhishek Maurya <124327945+Abhishek-TAMU@users.noreply.github.com>
Collaborator
Author
|
closing in favor of #246 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
eval_strategyinstead ofevaluation_strategyRelated issue number
Previously we had seen degraded performance in v4.41 of transformers as described in issue #201. After further evaluation described in the issue, the throughput degradation on llama3-8B was only 17%, only on 2 A100, and not at all on 4 A100, and that memory utilization was significantly improved by moving to 4.41.
How to verify the PR
Was the PR tested