Skip to content

Updated benchmark reference #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabianlim merged 1 commit into from
Jun 7, 2024
Merged

Updated benchmark reference #34

fabianlim merged 1 commit into from
Jun 7, 2024

Conversation

@achew010
Copy link
Contributor

@achew010 achew010 commented Jun 7, 2024

Updated a100 benchmark numbers after the FSDP-ignore -modules fix

@achew010 achew010 requested a review from fabianlim as a code owner June 7, 2024 04:21
@fabianlim
Copy link
Contributor

fabianlim commented Jun 7, 2024

@achew010 this CSV would correspond to numbers in #31 correct?

@achew010
Copy link
Contributor Author

achew010 commented Jun 7, 2024 •
edited
Loading

@achew010 this CSV would correspond to numbers in #31 correct?

@flim Yes the tables in the description of #31 are referenced from this csv

@fabianlim fabianlim merged commit 735cac8 into foundation-model-stack:fix/fsdp-ignore-modules Jun 7, 2024
fabianlim added a commit that referenced this pull request Jun 7, 2024
@fabianlim @achew010
Address Incorrect Ignoring of Base Layer Modules for FSDP with Kernels (
00febdc 
#31)

* properly ignore lora adapters

* handle qlora quant state

* improve fix

* further simplification of fix

* updated benchmark reference (#34)

---------

Co-authored-by: achew010 <165894159+achew010@users.noreply.github.com>
@achew010 achew010 deleted the achew/fix/fsdp-ignore-modules branch July 26, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabianlim fabianlim Awaiting requested review from fabianlim

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achew010 @fabianlim