Shift GPU Memory Computation to End of Benchmarking Script #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianlim
requested changes
Jun 5, 2024
scripts/benchmarks/benchmark.py
Outdated
| gpu_logs = pd.read_csv(gpu_log_filename, skipinitialspace=True) | ||
| peak_nvidia_mem_by_device_id, device_name = get_peak_mem_usage_by_device_id(gpu_logs) | ||
| experiment_stats[tag].update({ | ||
| RESULT_FIELD_RESERVED_GPU_MEM: peak_nvidia_mem_by_device_id.mean(), |
Contributor
There was a problem hiding this comment.
needs a comment what we are taking the mean over.
scripts/benchmarks/benchmark.py
Outdated
| except FileNotFoundError: | ||
| pass | ||
|
|
||
| if script_args['log_nvidia_smi'] is True: |
scripts/benchmarks/benchmark.py
Outdated
| RESULT_FIELD_DEVICE_NAME: device_name, | ||
| }) | ||
|
|
||
| if script_args['log_memory_hf'] is True and tag in experiment_stats.keys(): |
scripts/benchmarks/benchmark.py
Outdated
| k: v for k, v in experiment_stats[tag].items() | ||
| if any([prefix in k for prefix in memory_metrics_prefixes]) | ||
| } | ||
| if len(memory_metrics.keys())>0: |
Contributor
There was a problem hiding this comment.
pls lint the file with tox -e lint
fabianlim
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shifts all GPU memory computation from the end of each experiment to the end of the benchmarking script. This avoids the need to rerun experiments, instead the raw values are saved and the aggregated values are computed at the end across all the experiments in
gather_report.