Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some latest/on-going projects of fossasia #465

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

Dishebh
Copy link
Member

@Dishebh Dishebh commented Dec 17, 2019

Description

Updated the menu with the latest / on-going projects of fossasia

Related Issue

Fix for the issue #463

Motivation and Context

It is a feature request for the website.

Types of changes

  • Bug fix
  • New feature

Checklist:

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only one commit per issue.

Copy link
Member

@mariobehling mariobehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are downgrading a number of versions in package-lock.json. What is the reason?

@Dishebh
Copy link
Member Author

Dishebh commented Dec 18, 2019

You are downgrading a number of versions in package-lock.json. What is the reason?

@mariobehling while installing the required dependencies, it seems that many (like formatio1,2,0, [email protected]) have become outdated / unmaintained or their newer versions are available. Screenshot showing the same is attached below.
So, I audit fix the vulnerabilities there and installed the latest / alternate packages available. But, I don't know why the travis-ci checks are failing. Pls can you give me any ideas?

Screenshot from 2019-12-18 20-38-40

@Dishebh
Copy link
Member Author

Dishebh commented Dec 24, 2019

@mariobehling shall I try adding Greenkeeper to the project repo if it is not done before?

@mariobehling
Copy link
Member

This is confusing - the changes you make here are not all related to the issue. Please create an issue for changing dependencies for example. Only change in this PR what you actually state in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants