Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the year from 2019 to 2020. #51

Closed
wants to merge 31 commits into from

Conversation

Chaitanyassr
Copy link
Member

@Chaitanyassr Chaitanyassr commented Feb 4, 2020

fix issue #50

Before:

Screenshot (152)

After:

Screenshot (153)

@snitin315
Copy link
Member

Squash your commits , you have 7 commits for +1 change only.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding an image file?

@snitin315
Copy link
Member

Also the issue no. is linked in PR description not in PR title,
add Fixes #50 in your description and remove it from Title.

@snitin315
Copy link
Member

@shivaylamba @edjustice @HeinKhantZaw please review PR's carefully.

Copy link
Member

@shivaylamba shivaylamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be squashed

@Chaitanyassr Chaitanyassr changed the title fix issue #50 , change the year from 2019 to 2020. change the year from 2019 to 2020. Feb 18, 2020
@Chaitanyassr
Copy link
Member Author

Why adding an image file?

Elastic.png is already there in the main branch, i m not adding it. I did this pr long ago and after that Elastic.png was added. i merged the new changes made by the new PR(6th commit) and after that it started showing.

@snitin315
Copy link
Member

please rebase your branch and then squash the commits.

@Chaitanyassr
Copy link
Member Author

please rebase your branch and then squash the commits.

cloning the forked repo results in chaging the img file name(lowercase to uppercase). i m unable to rebase as local changes need to be commit first and doing so will leads to another change in image file.

@snitin315
Copy link
Member

If you are having trouble in reading just reset your branch. As this is a very minor change .

First abort if any rebase in process ,
git rebase --abort

git pull --rebase upstream master

git reset --hard upstream/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants