Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue 514] Simplify and improve submenu #567

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

areebbeigh
Copy link
Member

@areebbeigh areebbeigh commented Jan 18, 2019

Fixes #514

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request:

  • Delete labels "Engine", "Type", "Max"
  • Result tabs replace query parameter "Type"
  • Cleaner UI

Preview images below (click to expand).

Responsive behaviour

screenshot_20190118_162600

screenshot_20190118_162628

screenshot_20190118_162646

Search result types in tabs

screenshot_20190118_162743

@areebbeigh areebbeigh changed the title Issue 514 [Issue 514] Simplify and improve submenu Jan 18, 2019
@mariobehling
Copy link
Member

Thank you. Please help further and fix Travis in this PR.

@areebbeigh
Copy link
Member Author

areebbeigh commented Jan 28, 2019

@mariobehling Thank you for your response.

I doubt this PR should have anything to do with Travis' build issues since it's related solely to the front end HTML/CSS & JS.

I investigated Travis' issues separately and have made an issue #566 that aims at solving the initial fails Travis hits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify and improve submenu
2 participants