-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Refactor #9142
Open
T2703
wants to merge
19
commits into
fossasia:development
Choose a base branch
from
AdamMJennissen:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code Refactor #9142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request #9142 has too many files changed.
We can only review pull requests with up to 300 changed files, and this pull request has 302.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
These changes help refactor the code making it easier to maintain for the future and consistency for the software's architecture. With these changes it will help ensure that the code base is easier to understand and helps remove unnecessary lines of code that don't need to be there and can help speed up performance and can reduce the amount of bugs. These newer changes also help separate domain model and application logic.
More clarification on the changes:
In the event model the starts_at and ends_at date time field have been refactored to a TSTZRANGE data type since the date times were heavily connected it would be better to simplify them to a single field on the model and the new data type would help reduce the boilerplate code.
The domain driven bounded contexts on this project is not clarified enough and thus we created context modules such as event, financial, communication, and form. This will help maintain the DDD for the codebase.
Another change for the SOLID principles on this project. The new changes also help separate domain model and application logic by breaking a huge method into smaller sub methods making it easier to maintain and understand it also helps keeps simplicity.
Checklist
development
branch.