Skip to content

Conversation

@progmatic-99
Copy link
Contributor

Fixes frontend#7761

Short description of what this resolves:

Changes proposed in this pull request:

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 28, 2021

This pull request introduces 1 alert when merging 9ddc514 into 7ca377d - view on LGTM.com

new alerts:

  • 1 for Testing equality to None

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #8421 (9ddc514) into development (7ca377d) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8421      +/-   ##
===============================================
- Coverage        65.63%   65.60%   -0.04%     
===============================================
  Files              306      306              
  Lines            15935    15943       +8     
===============================================
  Hits             10459    10459              
- Misses            5476     5484       +8     
Impacted Files Coverage Δ
manage.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca377d...9ddc514. Read the comment docs.

@mariobehling mariobehling merged commit 72126f5 into fossasia:development Nov 28, 2021
Copy link
Contributor

@codedsun codedsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@progmatic-99 progmatic-99 deleted the group-resize-img branch December 13, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Groups: Thumbnail images and groups page header images are too big

3 participants