Skip to content

Conversation

@progmatic-99
Copy link
Contributor

Needed for frontend#7761

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #8273 (581969c) into development (d9653e7) will decrease coverage by 0.03%.
The diff coverage is 39.13%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8273      +/-   ##
===============================================
- Coverage        65.70%   65.67%   -0.04%     
===============================================
  Files              306      306              
  Lines            15843    15865      +22     
===============================================
+ Hits             10410    10419       +9     
- Misses            5433     5446      +13     
Impacted Files Coverage Δ
app/api/helpers/tasks.py 19.52% <25.00%> (+0.17%) ⬆️
app/api/groups.py 75.00% <44.44%> (-4.37%) ⬇️
app/api/schema/groups.py 100.00% <100.00%> (ø)
app/models/group.py 85.29% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9653e7...581969c. Read the comment docs.

@maze-runnar
Copy link
Contributor

looking into it.

@maze-runnar
Copy link
Contributor

Screenshot from 2021-10-09 08-00-46
Screenshot from 2021-10-09 08-00-21

@maze-runnar maze-runnar merged commit 1ba2642 into fossasia:development Oct 9, 2021
@progmatic-99
Copy link
Contributor Author

The banner image also needs to be resized.

@maze-runnar
Copy link
Contributor

I have done the changes, that are required similarly they are handled on event page.

@maze-runnar
Copy link
Contributor

We have to keep one original image, and at the time banner url is that original img for us

@progmatic-99
Copy link
Contributor Author

Did you check the size of both thumbnail and banner image ? Are they downsized??

@maze-runnar
Copy link
Contributor

Thumbnail yes, and we are not resizing banner. Will explain more in meeting if you have doubts.

@progmatic-99
Copy link
Contributor Author

@mariobehling said that banner image also has to be resized in the meeting, you were not in the meeting that day.

@progmatic-99 progmatic-99 deleted the frontend-7761 branch October 21, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants