Skip to content

Conversation

@sachinchauhan2889
Copy link
Contributor

@sachinchauhan2889 sachinchauhan2889 commented Aug 3, 2021

apply sorting by amount by sales in admin.sales page

Required for fossasia/open-event-frontend#7642

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #8142 (ba279c2) into development (92297f9) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #8142      +/-   ##
===============================================
- Coverage        65.77%   65.74%   -0.03%     
===============================================
  Files              305      305              
  Lines            15773    15806      +33     
===============================================
+ Hits             10375    10392      +17     
- Misses            5398     5414      +16     
Impacted Files Coverage Δ
app/api/admin_sales/events.py 66.66% <40.00%> (-21.43%) ⬇️
app/api/schema/events.py 98.70% <100.00%> (+0.05%) ⬆️
app/models/event.py 82.35% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92297f9...ba279c2. Read the comment docs.

@maze-runnar
Copy link
Contributor

resolve conflict.
changes are LGTM!!

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Aug 17, 2021

This pull request introduces 1 alert when merging b7403c2 into 0daf60a - view on LGTM.com

new alerts:

  • 1 for Unused import

maze-runnar
maze-runnar previously approved these changes Aug 18, 2021
Copy link
Contributor

@maze-runnar maze-runnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve lgtm issue.

@MeghalBisht MeghalBisht merged commit 5526bb7 into fossasia:development Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants