fix: Remove secret from DB and enforce env #6748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jan 16, 2020
app/instance.py
Outdated
| else: | ||
| random_secret = secrets.token_hex() | ||
| app.logger.warning(f'Using random secret "{ random_secret }" for development server. ' | ||
| 'This is NOT recommended. Set proper SECRET_KEY in .env or environment variables') |
There was a problem hiding this comment.
continuation line over-indented for visual indent
Codecov Report
@@ Coverage Diff @@
## development #6748 +/- ##
===============================================
- Coverage 65.42% 65.39% -0.04%
===============================================
Files 300 300
Lines 15330 15332 +2
===============================================
- Hits 10030 10026 -4
- Misses 5300 5306 +6
Continue to review full report at Codecov.
|
|
Issues
======
- Added 1
Complexity increasing per file
==============================
- app/instance.py 2
See the complete overview on Codacy |
niranjan94
reviewed
Jan 16, 2020
| exit(1) | ||
| else: | ||
| random_secret = secrets.token_hex() | ||
| app.logger.warning(f'Using random secret "{ random_secret }" for development server. ' |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6093