feat: add age_group field in ticket holder model #6744

snitin315 · 2020-01-15T16:01:36Z

Fixes #6742

Changes proposed in this pull request:

added age_group field in attendee schema and corresponding model.

Checklist

I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream development branch.
The unit tests pass locally with my changes
I have added necessary documentation (if appropriate)

All the functions created/modified in this PR contain relevant docstrings.

codecov · 2020-01-15T16:08:25Z

Codecov Report

Merging #6744 into development will increase coverage by 0.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           development   #6744      +/-   ##
==============================================
+ Coverage        65.39%   65.4%   +0.01%     
==============================================
  Files              300     300              
  Lines            15332   15337       +5     
==============================================
+ Hits             10026   10031       +5     
  Misses            5306    5306

Impacted Files	Coverage Δ
app/models/custom_form.py	`92.68% <ø> (ø)`	⬆️
app/api/schema/attendees.py	`98.33% <100%> (+0.08%)`	⬆️
app/models/ticket_holder.py	`79.41% <100%> (+0.3%)`	⬆️
app/api/helpers/static.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0183671...8b657ea. Read the comment docs.

iamareebjamal · 2020-01-16T07:47:46Z

This will accept any string as age group which was never the intention

snitin315 · 2020-01-16T08:48:48Z

This will accept any string as age group which was never the intention

@iamareebjamal On the frontend side I have created a dictionary for ageGroups as there is for genders. Hence the user can select only one of the options.

iamareebjamal · 2020-01-16T09:04:41Z

Doesn't matter really. I can set ooga booga and server will still accept it. Frontend checks are as useless as Windows Defender against viruses

snitin315 · 2020-01-16T09:09:48Z

Doesn't matter really. I can set ooga booga and server will still accept it. Frontend checks are as useless as Windows Defender against viruses

Any suggetions whats should be done?

iamareebjamal · 2020-01-16T09:12:15Z

Add server side validation that the age group is correct

houndci-bot · 2020-01-16T11:16:00Z

app/api/helpers/static.py

+    '30 to 39',
+    '40 to 49',
+    '50 or above'
+]


no newline at end of file

houndci-bot · 2020-01-16T11:32:54Z

app/api/helpers/static.py

+    '40 to 49',
+    '50 or above'
+]
+


blank line at end of file

iamareebjamal · 2020-01-16T11:48:48Z

This should be dynamic but will do it for now

iamareebjamal · 2020-01-17T10:57:27Z

app/api/helpers/static.py

+    '40 to 49',
+    '50 or above'
+]
+


Suggested change

iamareebjamal

Multiple Migration Heads

iamareebjamal · 2020-01-17T12:48:05Z

app/api/helpers/static.py

+    '30 to 39',
+    '40 to 49',
+    '50 or above'
+]


Suggested change

]

]

niranjan94 · 2020-01-17T13:00:43Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 1

See the complete overview on Codacy

app/api/helpers/static.py

snitin315 requested a review from kushthedude January 15, 2020 16:02

kushthedude previously approved these changes Jan 16, 2020

View reviewed changes

kushthedude requested a review from iamareebjamal January 16, 2020 03:04

snitin315 dismissed kushthedude’s stale review via 4044add January 16, 2020 11:15

houndci-bot reviewed Jan 16, 2020

View reviewed changes

app/api/helpers/static.py Outdated

'30 to 39',

'40 to 49',

'50 or above'

]

Copy link

houndci-bot Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

snitin315 force-pushed the development branch 2 times, most recently from ae7dbff to c99dd86 Compare January 16, 2020 11:32

houndci-bot reviewed Jan 16, 2020

View reviewed changes

app/api/helpers/static.py Outdated

'40 to 49',

'50 or above'

]

Copy link

houndci-bot Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line at end of file

iamareebjamal reviewed Jan 17, 2020

View reviewed changes

app/api/helpers/static.py Outdated

'40 to 49',

'50 or above'

]

Copy link

Member

iamareebjamal Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

iamareebjamal changed the title ~~add age_group field in ticket holder model~~ feat: add age_group field in ticket holder model Jan 17, 2020

auto-label bot added the feature label Jan 17, 2020

iamareebjamal requested changes Jan 17, 2020

View reviewed changes

snitin315 force-pushed the development branch 2 times, most recently from 661a9d5 to 6938ec4 Compare January 17, 2020 12:45

iamareebjamal reviewed Jan 17, 2020

View reviewed changes

app/api/helpers/static.py Outdated

'30 to 39',

'40 to 49',

'50 or above'

]

Copy link

Member

iamareebjamal Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

]

]

add age_group field in ticket holder model

8b657ea

snitin315 force-pushed the development branch from 6938ec4 to 8b657ea Compare January 17, 2020 12:56

iamareebjamal approved these changes Jan 17, 2020

View reviewed changes

kushthedude approved these changes Jan 17, 2020

View reviewed changes

niranjan94 reviewed Jan 17, 2020

View reviewed changes

app/api/helpers/static.py Show resolved Hide resolved

iamareebjamal merged commit b69df88 into fossasia:development Jan 17, 2020

snitin315 mentioned this pull request Jan 18, 2020

feat: add ageGroup Field in attendee form fossasia/open-event-frontend#3803

Merged

codedsun mentioned this pull request Jan 18, 2020

Error in migrations #6753

Closed

feat: add age_group field in ticket holder model #6744

feat: add age_group field in ticket holder model #6744

Uh oh!

Conversation

snitin315 commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes proposed in this pull request:

Checklist

Uh oh!

codecov bot commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

iamareebjamal commented Jan 16, 2020

Uh oh!

snitin315 commented Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamareebjamal commented Jan 16, 2020

Uh oh!

snitin315 commented Jan 16, 2020

Uh oh!

iamareebjamal commented Jan 16, 2020

Uh oh!

houndci-bot Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

houndci-bot Jan 16, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal commented Jan 16, 2020

Uh oh!

iamareebjamal Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

iamareebjamal left a comment

Choose a reason for hiding this comment

Uh oh!

iamareebjamal Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

niranjan94 commented Jan 17, 2020

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

snitin315 commented Jan 15, 2020 •

edited

Loading

codecov bot commented Jan 15, 2020 •

edited

Loading

snitin315 commented Jan 16, 2020 •

edited

Loading