Skip to content

Conversation

@shreyanshdwivedi
Copy link
Member

Fixes #6401

Short description of what this resolves:

Implement route to get transaction status of the payment to verify if payment is actually made or not

Changes proposed in this pull request:

  • adds a route to check the transaction status

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

@auto-label auto-label bot added the feature label Aug 20, 2019
@shreyanshdwivedi
Copy link
Member Author

shreyanshdwivedi commented Aug 20, 2019

This PR can be merged only after #6399 is merged.
The hound errors will automatically be resolved once the mentioned PR is merged

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #6402 into development will decrease coverage by 0.09%.
The diff coverage is 5.88%.

Impacted file tree graph

@@              Coverage Diff              @@
##           development   #6402     +/-   ##
=============================================
- Coverage        64.49%   64.4%   -0.1%     
=============================================
  Files              288     288             
  Lines            15039   15056     +17     
=============================================
- Hits              9700    9697      -3     
- Misses            5339    5359     +20
Impacted Files Coverage Δ
app/api/orders.py 26.25% <5.88%> (-0.91%) ⬇️
app/api/helpers/scheduled_jobs.py 20.93% <0%> (-3.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31c0b86...530b3d7. Read the comment docs.

@fossasia fossasia deleted a comment Aug 23, 2019
@fossasia fossasia deleted a comment Aug 23, 2019
@shreyanshdwivedi shreyanshdwivedi force-pushed the transactionStatus branch 2 times, most recently from 768c404 to 03299e0 Compare August 23, 2019 18:39
@fossasia fossasia deleted a comment Aug 23, 2019
@fossasia fossasia deleted a comment Aug 23, 2019
@shreyanshdwivedi
Copy link
Member Author

@uds5501 @mrsaicharan1 please review this

@shreyanshdwivedi
Copy link
Member Author

@mrsaicharan1 please review

Copy link
Member

@mrsaicharan1 mrsaicharan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I've also created a method which serves as a helper to hit the endpoint instead of repeating code in each of the route's mapped functions. Please make use of it :)

def hit_paytm_endpoint(url, head, body=None):

@shreyanshdwivedi
Copy link
Member Author

@mrsaicharan1 I cannot use the helper hit_paytm_endpoint because the Transaction Status API doesn't ask us to segregate the paytmParams in head and body but your helper does so.
This API is different from others. Please take a look at https://developer.paytm.com/docs/transaction-status-api/

@shreyanshdwivedi
Copy link
Member Author

@iamareebjamal please review

@iamareebjamal iamareebjamal merged commit 46c5fdf into fossasia:development Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement route to get transaction status of the payment

5 participants